Update vcpkg version dependencies#2718
Merged
antkmsft merged 3 commits intoAzure:mainfrom Aug 9, 2021
antkmsft:versions
Merged
Update vcpkg version dependencies#2718antkmsft merged 3 commits intoAzure:mainfrom antkmsft:versions
antkmsft merged 3 commits intoAzure:mainfrom
antkmsft:versions
Conversation
antkmsft
requested review from
a team,
Jinming-Hu,
RickWinter,
ahsonkhan,
danieljurek,
gearama,
katmsft,
schaabs,
vhvb1989 and
vinjiang
as code owners
antkmsft
added
blocking-release
antkmsft
commented
Aug 9, 2021
vhvb1989
approved these changes
Aug 9, 2021
Member
vhvb1989
left a comment
vhvb1989
left a comment
There was a problem hiding this comment.
Asking to update Key Vault to depend on azure-core 1.2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2702
VcPkg have a bug currently so at a moment we can't use
version>=andbuiltin-baseline: [Azure-*] Remove version constraint microsoft/vcpkg#19299 (comment)Identity depends on
core 1.2.0.Keyvault-Keys depends on
core 1.1.0- @vhvb1989, please correct me if I am wrong.Storage depends on
core 1.0.0, and all storage libs that depend onstorage-commondo depend on12.0.0. But datalake depends onstorage-blobs 12.1.0- @Jinming-Hu, please correct me if I am wrong. This also applies to the new azure-storage-queues lib.Keyvault-Secrets was missing a core dependency in the vcpkg manifest. Per cmakelists.txt, it was depending on
core 1.1.0. I updated vcpkg manifest files to reflect that - @gearama, please correct me if I am wrong.